| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: do {} while (0) nitpick |
| Date: | 2020-05-01 21:32:11 |
| Message-ID: | 25358.1588368731@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Steele <david(at)pgmasters(dot)net> writes:
> On 4/30/20 9:52 PM, Bruce Momjian wrote:
>> On Thu, Apr 30, 2020 at 09:51:10PM -0400, Tom Lane wrote:
>>> Yeah. I'd call these actual bugs, and perhaps even back-patch worthy.
>> Agreed. Those semicolons could easily create bugs.
> +1. The patch looks good to me.
Grepping showed me that there were some not-do-while macros that
also had trailing semicolons. These seem just as broken, so I
fixed 'em all.
There are remaining instances of this antipattern in the flex-generated
scanners, which we can't do anything about; and in pl/plperl/ppport.h,
which we shouldn't do anything about because that's upstream-generated
code. (I wonder though if there's a newer version available.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Cary Huang | 2020-05-01 22:16:46 | Re: Internal key management system |
| Previous Message | Ranier Vilela | 2020-05-01 21:31:37 | Re: Unify drop-by-OID functions |