Re: Proposal: Make cfbot fail on patches not created by "git format-patch"

On Fri, 16 May 2025 at 12:05, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 16 May 2025, at 11:52, Jelte Fennema-Nio <me(at)jeltef(dot)nl> wrote:
>
> > Does anyone have strong opposition to this? To be clear, it means we don't run CI on patches created by piping "git diff" to a file anymore, as a way to nudge submitters into providing useful commit messages.
>
> Disclaimer: I wasn't in the session (due to conflicting interesting sessions)
> so I might be raising points/questions already answered.
>
> Is this really lowering the bar for new contributors? I've always held "be
> liberal in what you accept" as a gold standard for projects I'm involved in, to
> remove barriers to entry. Good commit messages are obviously very important,
> but having your patch rejected (yes, I know, failing to apply) might not be
> strongest motivator for achieving this.

Lowering the bar for new contributors wasn't the purpose of this
change in policy. It's meant to reduce the work that committers and
reviewers have to do, which then in turn would result in quicker
reviews/commits. In my experience with other open source projects new
contributors are usually fine with adhering to project standards, if
they are told what those standards are. e.g. these days basically
every popular open source project is running a CI job that fails if
the auto-formatter fails.