Re: Proposal: Make cfbot fail on patches not created by "git format-patch"

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
Date: 2025-05-16 16:05:38
Message-ID: 3DEAFBC1-2F52-44E5-A56D-021D97F673D9@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 16 May 2025, at 11:52, Jelte Fennema-Nio <me(at)jeltef(dot)nl> wrote:

> Does anyone have strong opposition to this? To be clear, it means we don't run CI on patches created by piping "git diff" to a file anymore, as a way to nudge submitters into providing useful commit messages.

Disclaimer: I wasn't in the session (due to conflicting interesting sessions)
so I might be raising points/questions already answered.

Is this really lowering the bar for new contributors? I've always held "be
liberal in what you accept" as a gold standard for projects I'm involved in, to
remove barriers to entry. Good commit messages are obviously very important,
but having your patch rejected (yes, I know, failing to apply) might not be
strongest motivator for achieving this.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2025-05-16 16:12:38 Re: wrong query results on bf leafhopper
Previous Message Tom Lane 2025-05-16 16:05:10 Re: C extension compilation failed while using PG 17.2 on mac m1