Re: CI: Add task that runs pgindent

From: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: CI: Add task that runs pgindent
Date: 2025-10-23 09:40:12
Message-ID: CAGECzQTotzNaniT-tpz5Eg85tO=B_0wOO2SnOuK0hiXqHwVwMg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 22 Oct 2025 at 14:06, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> I like the different shape and symbol, but I would probably keep it green to
> indicate that it's informational rather than actionable. We don't want a
> flurry of patch re-submissions with only whitespace changes eating CI resources
> when the previous build was successful. Just my €0,02.

I understand the concern. So I tried out making the icon green now
(see attached), but it looks a bit weird imo. Unless some others
prefer the green too (or have some other idea for an icon), I'm
inclined to keep it the yellow/orange color it is now. If we actually
do get a bunch of useless re-submissions, we can consider changing it.

Attachment Content-Type Size
image/png 19.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Tselebrovskiy 2025-10-23 09:47:13 001_password.pl fails with --without-readline
Previous Message Shinya Kato 2025-10-23 09:36:01 Re: Add wal_fpi_bytes_[un]compressed to pg_stat_wal