Re: CI: Add task that runs pgindent

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: CI: Add task that runs pgindent
Date: 2025-10-23 14:27:11
Message-ID: 12247711-FC64-48A5-B8A5-8989B1490F36@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 23 Oct 2025, at 11:40, Jelte Fennema-Nio <me(at)jeltef(dot)nl> wrote:
>
> On Wed, 22 Oct 2025 at 14:06, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> I like the different shape and symbol, but I would probably keep it green to
>> indicate that it's informational rather than actionable. We don't want a
>> flurry of patch re-submissions with only whitespace changes eating CI resources
>> when the previous build was successful. Just my €0,02.
>
> I understand the concern. So I tried out making the icon green now
> (see attached), but it looks a bit weird imo. Unless some others
> prefer the green too (or have some other idea for an icon), I'm
> inclined to keep it the yellow/orange color it is now. If we actually
> do get a bunch of useless re-submissions, we can consider changing it.

If the set of icons grows from the self-explanatory red/green we should perhaps
document what the diffent colors mean in the help page?

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2025-10-23 14:39:21 Re: Proposal: Allow excluding specific file patterns in pg_checksums
Previous Message Kirill Reshke 2025-10-23 14:13:03 Re: WIP: parallel GiST index builds