Re: [PATCH v1] psql: Do not complete JSON format for COPY FROM

On Tue, Nov 3, 2026 at 8:23 PM Koshino Taiki <koshino(at)sraoss(dot)co(dot)jp> wrote:

> The attached patch checks the COPY direction and offers "json" only
> for COPY TO. This applies to both COPY and \copy completion.
>
>
Hi Taiki,

I reviewed v1 on master with assertions enabled. The build and before/after
Readline completion checks pass. Console checks confirm that both `COPY`
and `\copy` reject `FORMAT JSON` for `FROM` and accept it for `TO`, matching
the backend logic [1]. The patch looks correct to me.

[1]
https://github.com/postgres/postgres/blob/126976a8ffcfa47f40d3df09243ebf4606001912/src/backend/commands/copy.c#L994-L998

Thanks,
Sho

--
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝