Re: [PATCH v1] psql: Do not complete HEADER MATCH for COPY TO

On Tue, Nov 3, 2026 at 8:24 PM Koshino Taiki <koshino(at)sraoss(dot)co(dot)jp> wrote:

> The attached patch checks the COPY direction and offers "MATCH" only
> for COPY FROM. The boolean values remain available in both
> directions, and the change applies to both COPY and \copy completion.
>

Hi Taiki,

I reviewed v1 on master with assertions enabled. The build and before/after
Readline completion checks pass for both `COPY` and `\copy`: `MATCH` is
removed for `TO` and retained for `FROM`, while `true` and `false` remain
available.

Console checks confirm that both commands reject `HEADER MATCH` for `TO` [1]
and accept it for `FROM`, checking the column names.
I don't see any issues with this patch.

[1]
https://github.com/postgres/postgres/blob/126976a8ffcfa47f40d3df09243ebf4606001912/src/backend/commands/copy.c#L434-L441

Thanks,
Sho

--
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝