| From: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] Fix tab completion for DROP INDEX CONCURRENTLY |
| Date: | 2026-10-21 07:33:35 |
| Message-ID: | CAG7L5+4+S-d-EBcMJMRMBtRODhp4g0y7i3JirGuJRy_Pu8vjdw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 21, 2026 at 4:15 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> We already offer completion for optional clauses that make the default
> explicit,
> such as WITH after REFRESH MATERIALIZED VIEW CONCURRENTLY <name>.
> So I think v1 is fine too.
>
Hi Fujii-san,
Thanks, that makes sense. How about keeping v1 for now and addressing
the incorrect completion after `IF` separately by improving completion
for `IF EXISTS` in the affected `DROP` commands?
Shihao, would that work for you?
Regards,
Sho
--
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
*Sho Ito (Sean)*
E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-10-21 08:07:28 | Re: [PG19] Sequence sync stops when the subscription owner can't SET ROLE to a sequence owner |
| Previous Message | Sho Ito | 2026-10-21 07:19:57 | Re: [PATCH] Fix leaked hash scans in pg_listening_channels() |