| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] Fix tab completion for DROP INDEX CONCURRENTLY |
| Date: | 2026-10-21 08:44:05 |
| Message-ID: | CAHGQGwHgq4rx9A9ko=3sH-VKssxbwT8N7RFZRVAYSPnP1GieUg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 21, 2026 at 4:34 PM Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> wrote:
> Thanks, that makes sense. How about keeping v1 for now
+1
> and addressing
> the incorrect completion after `IF` separately by improving completion
> for `IF EXISTS` in the affected `DROP` commands?
IIUC, currently, psql does not offer tab completion for "IF EXISTS" or
"IF NOT EXISTS". But, are you suggesting adding support for these clauses
across commands? I'm not sure how much benefit this would provide
relative to the implementation effort.
BTW, since "if" is not a reserved keyword, an index can be named "if".
What should tab completion offer after "DROP INDEX CONCURRENTLY if"
in that case?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Nitin Motiani | 2026-10-21 08:32:00 | [PATCH v1] Fix for bug #19770 : Reject NO INHERIT not-null constraints copied by LIKE to partitioned tables |