| From: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
|---|---|
| To: | Joel Jacobson <joel(at)compiler(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix leaked hash scans in pg_listening_channels() |
| Date: | 2026-10-21 07:19:57 |
| Message-ID: | CAG7L5+7ZorRvB7BGHQ8wbuuA7Lb4tpAsmOjHp3jwT5Qiv+jx9g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 19, 2026 at 2:42 PM Joel Jacobson <joel(at)compiler(dot)org> wrote:
> Attached patch uses InitMaterializedSRF() to complete the scan
> before returning rows, following 257c8231bf.
>
Hi Joel,
I reviewed the attached patch on master with assertions enabled. Before the
fix,
repeated target-list calls under `LIMIT` in one transaction cause
a backend crash with `PANIC: ERRORDATA_STACK_SIZE exceeded`. With the patch,
the same workload completes without warnings or errors.
The materialization approach follows the SRF guidance in `funcapi.h` and
looks good to me.
Thanks,
Sho
--
=======================================
*Sho Ito (Sean)*
E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sho Ito | 2026-10-21 07:33:35 | Re: [PATCH v1] Fix tab completion for DROP INDEX CONCURRENTLY |
| Previous Message | Yilin Zhang | 2026-10-21 07:16:50 | Re: [PATCH] pageinspect: validate line pointers before using them |