Re: print_path is missing GatherMerge and CustomScan support

On Wed, Jul 18, 2018 at 11:52 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Jul 18, 2018 at 02:35:23PM +0900, Masahiko Sawada wrote:
>> Hi,
>>
>> While debugging planner I realized that print_path() function is not
>> aware of both GatherMerge path and CustomScan path. Attached small
>> patch fixes it.
>
> Good catch. Those should be backpatched. While I am looking at this
> stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
> T_MergeAppend and not T_MergeAppendPath.
>
> --- a/src/backend/optimizer/util/pathnode.c
> +++ b/src/backend/optimizer/util/pathnode.c
> @@ -3817,7 +3817,7 @@ do { \
> }
> break;
>
> - case T_MergeAppend:
> + case T_MergeAppendPath:
> {
> MergeAppendPath *mapath
>
> This is new as of f49842d1 in v11.

Yes that's right. Thanks for taking care of it.

> Robert, Ashutosh, am I missing
> something?

You used my personal email id by mistake, I think. I have removed it
and added by EDB email address.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company