| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)gmail(dot)com> |
| Subject: | Re: print_path is missing GatherMerge and CustomScan support |
| Date: | 2018-07-18 06:22:02 |
| Message-ID: | 20180718062202.GC8565@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 18, 2018 at 02:35:23PM +0900, Masahiko Sawada wrote:
> Hi,
>
> While debugging planner I realized that print_path() function is not
> aware of both GatherMerge path and CustomScan path. Attached small
> patch fixes it.
Good catch. Those should be backpatched. While I am looking at this
stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
T_MergeAppend and not T_MergeAppendPath.
--- a/src/backend/optimizer/util/pathnode.c
+++ b/src/backend/optimizer/util/pathnode.c
@@ -3817,7 +3817,7 @@ do { \
}
break;
- case T_MergeAppend:
+ case T_MergeAppendPath:
{
MergeAppendPath *mapath
This is new as of f49842d1 in v11. Robert, Ashutosh, am I missing
something?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-07-18 06:34:45 | Re: [bug fix] Produce a crash dump before main() on Windows |
| Previous Message | Tsunakawa, Takayuki | 2018-07-18 06:09:57 | RE: [bug fix] Produce a crash dump before main() on Windows |