Re: print_path is missing GatherMerge and CustomScan support

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: print_path is missing GatherMerge and CustomScan support
Date: 2018-07-18 06:55:24
Message-ID: 20180718065524.GE8565@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 18, 2018 at 12:15:25PM +0530, Ashutosh Bapat wrote:
> On Wed, Jul 18, 2018 at 11:52 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> On Wed, Jul 18, 2018 at 02:35:23PM +0900, Masahiko Sawada wrote:
>>> Hi,
>>>
>>> While debugging planner I realized that print_path() function is not
>>> aware of both GatherMerge path and CustomScan path. Attached small
>>> patch fixes it.
>>
>> Good catch. Those should be backpatched. While I am looking at this
>> stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
>> T_MergeAppend and not T_MergeAppendPath.
>>
>> This is new as of f49842d1 in v11.
>
> Yes that's right. Thanks for taking care of it.

Thanks for the confirmation. Robert, do you want to take care of this
issue or should I?

>> Robert, Ashutosh, am I missing
>> something?
>
> You used my personal email id by mistake, I think. I have removed it
> and added by EDB email address.

My sincere apologies. I have not been careful.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2018-07-18 07:17:24 Re: [bug fix] Produce a crash dump before main() on Windows
Previous Message Ashutosh Bapat 2018-07-18 06:45:25 Re: print_path is missing GatherMerge and CustomScan support