| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench more operators & functions |
| Date: | 2017-05-30 05:52:06 |
| Message-ID: | CAFj8pRDvSWEA21JrE7bbqJLqSFoSUHG-kkahUA7-eOEKg_ChOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2017-05-30 7:19 GMT+02:00 Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>:
>
> [doc about CASE...]
>>>
>>
>> I've improved it in attached v11:
>> - add a link to the CASE full documentation
>> - add an example expression with CASE ...
>>
>
> Do you think I should improve the doc further?
I am sorry, I didn't look there yet
The patch looks ok, but the main issue is missing regress tests. I know so
it is another patch. But it should be placed differently
1. first patch - initial infrastructure for pgbench regress tests
2. this patch + related regress tests
Regards
Pavel
>
>
> --
> Fabien.
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2017-05-30 06:30:10 | Re: Surjective functional indexes |
| Previous Message | Beena Emerson | 2017-05-30 05:29:45 | Re: Adding support for Default partition in partitioning |