Re: pgbench more operators & functions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench more operators & functions
Date: 2017-05-30 09:47:26
Message-ID: alpine.DEB.2.20.1705301135500.30762@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


> The patch looks ok,

Ok.

> but the main issue is missing regress tests.

Yes, I agree.

> I know so it is another patch. But it should be placed differently

> 1. first patch - initial infrastructure for pgbench regress tests
> 2. this patch + related regress tests

Yep. I have no control about the display order, committers are too few and
overbooked, pgbench is not necessarily a priority, so I can only wait for
the non-regression test improvements to get committed some day before
updating/adding tests for the other patches in the queue (query result in
variable, utf8 variable names...).

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Shaplov 2017-05-30 10:15:47 Re: pgbench tap tests & minor fixes
Previous Message Rafia Sabih 2017-05-30 09:28:04 Effect of changing the value for PARALLEL_TUPLE_QUEUE_SIZE