| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Robert Haas <robertmhaas(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Variable substitution in psql backtick expansion |
| Date: | 2017-09-04 17:01:17 |
| Message-ID: | CAFj8pRBEy9uAfNpu34vOwky0=k=ZYBCMzCTUST-RwF7KaMUU0A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2017-09-04 18:56 GMT+02:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> I wrote:
> > ... Or maybe we should shorten this
> > variable name so it doesn't force reformatting of all this text.
> > Possible ideas include "DB_VERSION_NAME", "SERVER_VER_NAME", or
> > "SERVER_VERSION_STR". (The last saves only one character, whereas
> > we really need to save two if we're trying not to be wider than any
> > other documented variable.)
>
> Just had another idea: maybe make the new variable names
>
> SERVER_VERSION_S
> SERVER_VERSION_N
> VERSION_S
> VERSION_N
>
> "_S" could usefully be read as either "string" or "short", and probably
> we should document it as meaning "short". This way avoids creating any
> weird inconsistencies with the existing precedent of the VERSION variable.
>
-1
With respect, it doesn't look well and intuitive.
SERVER_VERSION_STR looks better than this.
I can live very well with SERVER_VERSION_STR and SERVER_VERSION_NUM
Regards
Pavel
>
> regards, tom lane
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Tiikkaja | 2017-09-04 17:05:57 | Re: INSERT .. ON CONFLICT DO SELECT [FOR ..] |
| Previous Message | Konstantin Knizhnik | 2017-09-04 17:01:03 | Re: JIT compiling expressions/deform + inlining prototype v2.0 |