Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY

From: Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY
Date: 2021-05-06 11:22:56
Message-ID: 7b1ff3fb-2002-a09e-8e60-1b79086ac294@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06.05.2021 08:35, Amit Langote wrote:
> On Wed, May 5, 2021 at 7:59 PM Pavel Luzanov
> <p(dot)luzanov(at)postgrespro(dot)ru> wrote:
>> I found this in the documentation, section '5.11.3. Partitioning
>> Using Inheritance'[1]: "Some operations require a stronger lock when
>> using declarative partitioning than when using table inheritance. For
>> example, removing a partition from a partitioned table requires
>> taking an ACCESS EXCLUSIVE lock on the parent table, whereas a SHARE
>> UPDATE EXCLUSIVE lock is enough in the case of regular inheritance."
>> This point is no longer valid with some restrictions. If the table
>> has a default partition, then removing a partition still requires
>> taking an ACCESS EXCLUSIVE lock. May be make sense to add some
>> details about DETACH CONCURRENTLY to the section '5.11.2.2. Partition
>> Maintenance' and completely remove this point? 1.
>> https://www.postgresql.org/docs/devel/ddl-partitioning.html#DDL-PARTITIONING-USING-INHERITANCE
> That makes sense, thanks for noticing. How about the attached?

I like it.
Especially the link to the ALTER TABLE, this avoids duplication of all
the nuances of the the DETACH .. CONCURRENTLY.

--
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-05-06 11:31:23 Re: Small issues with CREATE TABLE COMPRESSION
Previous Message Matthias van de Meent 2021-05-06 11:10:30 Re: MaxOffsetNumber for Table AMs