Re: Proposal: Conflict log history table for Logical Replication

On Tue, May 5, 2026 at 9:37 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Tue, May 5, 2026 at 8:26 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Mon, May 4, 2026 at 6:41 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > >
> > > PFA, poc patch for the same.
>
> I like the idea of PoC. It simplifies the implementation.
>
> > >
> >
> > I know it is POC but I think you need more work to prevent manual
> > inserts/updates on conflict tables.
> >
>
> I think CheckValidResultRel() handles it.
>
> postgres=# insert into pg_conflict.pg_conflict_16391 values (0);
> ERROR: cannot modify or insert data into conflict log table "pg_conflict_16391"
> DETAIL: Conflict log tables are system-managed and only support
> cleanup via DELETE or TRUNCATE

I think we can tweak a bit and pg_class_aclmask_ext() we can only
allow truncate/delete on pg_conflict and block insert and update, here
is the modified version. Please let me know your thoughts.

--
Regards,
Dilip Kumar
Google