Re: Proposal: Conflict log history table for Logical Replication

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com>
Subject: Re: Proposal: Conflict log history table for Logical Replication
Date: 2026-05-05 04:06:55
Message-ID: CAJpy0uAi-gyzUJEqb8JzmRRVs9s7G1_7Hf+2ha7FjTnVgcON7w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 5, 2026 at 8:26 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, May 4, 2026 at 6:41 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > PFA, poc patch for the same.

I like the idea of PoC. It simplifies the implementation.

> >
>
> I know it is POC but I think you need more work to prevent manual
> inserts/updates on conflict tables.
>

I think CheckValidResultRel() handles it.

postgres=# insert into pg_conflict.pg_conflict_16391 values (0);
ERROR: cannot modify or insert data into conflict log table "pg_conflict_16391"
DETAIL: Conflict log tables are system-managed and only support
cleanup via DELETE or TRUNCATE

thanks
Shveta

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Henson Choi 2026-05-05 04:26:56 Re: Row pattern recognition
Previous Message shveta malik 2026-05-05 04:02:00 Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE