Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments

Hi Tom,

Thanks for your feedback.

> In this case the problem is that the cleanup pattern only accounts for
> one trailing space. But a variant of this, which I think affects many
> of the steps in the patch, is that there could be tab(s) there. You
> should fix the patterns to allow any number of spaces/tabs at the
> spots where they currently expect just one space. This might result
> in finding cleanups they miss now.

Fair point. Fixed.

> Another amusing diff I noticed:
>
> [...]
>
> Clearly, this is somebody's off-by-one-key typo, and the correct
> fix is s/&/*/. I suspect that fixing that manually is the most
> expedient answer, rather than trying to make pg_bsd_indent smart
> enough to DTRT.

Agree.

> One other nitpick is that the patch itself needs to be run through
> pgperltidy (which has different opinions than your editor about
> tabs vs spaces, apparently).

Fixed in v7.

--
Best regards,
Aleksander Alekseev