Re: Per-table storage parameters for TableAM/IndexAM extensions

From: Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com>
To: Jelte Fennema <postgres(at)jeltef(dot)nl>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Per-table storage parameters for TableAM/IndexAM extensions
Date: 2022-01-18 17:14:10
Message-ID: CAFF0-CFSy0wJCTfjJ6QLsHZGfFLAVKiHzgdTJyNnzqJfWpwh7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 17, 2022 at 4:47 PM Jelte Fennema <postgres(at)jeltef(dot)nl> wrote:
>
> Big +1, this is a great addition!
>
> I think it would be very useful if there were some tests for this new
> feature. Something similar to the tests for storage parameters for
> index AMs in src/test/modules/dummy_index_am.
>
Sure, I will refer to the index AM test and add the test cases needed.

> Apart from that I think the documentation for table storage parameters
> needs to be updated in doc/src/sgml/ref/create_table.sgml. It now
> needs to indicate that these parameters are different for each table
> access method. Similar to this paragraph in the create index storage
> parameter section of the docs:

Sure, I will add the documentation part for this.

As of now, I have fixed the comments from Dilip & Rushabh and have
done some more changes after internal testing and review. Please find
the latest patch attached.

Thanks & Regards
SadhuPrasad
www.EnterpriseDB.com

Attachment Content-Type Size
v2-0001-PATCH-v2-Per-table-storage-parameters-for-TableAM.patch application/octet-stream 14.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-01-18 17:44:13 Re: Adding CI to our tree
Previous Message Tom Lane 2022-01-18 17:04:21 Re: Replace uses of deprecated Python module distutils.sysconfig