Re: Per-table storage parameters for TableAM/IndexAM extensions

From: Jelte Fennema <postgres(at)jeltef(dot)nl>
To: Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Per-table storage parameters for TableAM/IndexAM extensions
Date: 2022-01-17 11:17:16
Message-ID: CAGECzQRDj2UrOvg-rJfWdTAPjh0WEjt7xBWV61bGTOH7jONcPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Big +1, this is a great addition!

I think it would be very useful if there were some tests for this new
feature. Something similar to the tests for storage parameters for
index AMs in src/test/modules/dummy_index_am.

Apart from that I think the documentation for table storage parameters
needs to be updated in doc/src/sgml/ref/create_table.sgml. It now
needs to indicate that these parameters are different for each table
access method. Similar to this paragraph in the create index storage
parameter section of the docs:

> Each index method has its own set of allowed storage parameters.
> The B-tree, hash, GiST and SP-GiST index methods all accept this
> parameter

Jelte

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-01-17 11:23:01 Re: row filtering for logical replication
Previous Message Alexander Pyhalov 2022-01-17 10:42:10 Re: Asymmetric partition-wise JOIN