Re: Recent cpluspluscheck failures

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: John Naylor <john(dot)naylor(at)postgresql(dot)org>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Recent cpluspluscheck failures
Date: 2021-09-23 19:13:51
Message-ID: CAFBsxsG6aKGHm2Nz5RFZSme4kRx0dOQ5Cu8AGEtp8xhfBAZaRA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 23, 2021 at 2:37 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> On HEAD, I see these headers failing to compile standalone:
>
> $ src/tools/pginclude/cpluspluscheck
> In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
> ./src/include/common/unicode_east_asian_fw_table.h:3:32: error: elements
of array 'const mbinterval east_asian_fw []' have incomplete type
> static const struct mbinterval east_asian_fw[] = {
> ^~~~~~~~~~~~~
> ./src/include/common/unicode_east_asian_fw_table.h:3:32: error: storage
size of 'east_asian_fw' isn't known

Okay, this file is used similarly to
src/include/common/unicode_combining_table.h, which has an exception in the
check script, so I'll add another exception.

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2021-09-23 19:15:12 Re: Column Filtering in Logical Replication
Previous Message Robert Haas 2021-09-23 19:13:50 Re: preserving db/ts/relfilenode OIDs across pg_upgrade (was Re: storing an explicit nonce)