Recent cpluspluscheck failures

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Naylor <john(dot)naylor(at)postgresql(dot)org>, Amit Kapila <akapila(at)postgresql(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Recent cpluspluscheck failures
Date: 2021-09-23 18:37:50
Message-ID: 2324798.1632422270@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On HEAD, I see these headers failing to compile standalone:

$ src/tools/pginclude/cpluspluscheck
In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
./src/include/common/unicode_east_asian_fw_table.h:3:32: error: elements of array 'const mbinterval east_asian_fw []' have incomplete type
static const struct mbinterval east_asian_fw[] = {
^~~~~~~~~~~~~
./src/include/common/unicode_east_asian_fw_table.h:3:32: error: storage size of 'east_asian_fw' isn't known
In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
./src/include/replication/worker_internal.h:60:2: error: 'FileSet' does not name a type
FileSet *stream_fileset;
^~~~~~~

The first of these is evidently the fault of bab982161 (Update display
widths as part of updating Unicode), which introduced that header.
The second seems to have been introduced by 31c389d8d (Optimize fileset
usage in apply worker).

Please fix.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-09-23 18:51:08 Re: OpenSSL 3.0.0 compatibility
Previous Message Robert Haas 2021-09-23 18:26:17 Re: [Patch] ALTER SYSTEM READ ONLY