Re: Recent cpluspluscheck failures

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Recent cpluspluscheck failures
Date: 2021-09-23 19:24:16
Message-ID: 2369201.1632425056@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> On Thu, Sep 23, 2021 at 2:37 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> On HEAD, I see these headers failing to compile standalone:
>> $ src/tools/pginclude/cpluspluscheck
>> In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
>> ./src/include/common/unicode_east_asian_fw_table.h:3:32: error: elements
> of array 'const mbinterval east_asian_fw []' have incomplete type

> Okay, this file is used similarly to
> src/include/common/unicode_combining_table.h, which has an exception in the
> check script, so I'll add another exception.

OK, but see also src/tools/pginclude/headerscheck.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-09-23 19:28:04 Re: very long record lines in expanded psql output
Previous Message Tomas Vondra 2021-09-23 19:15:12 Re: Column Filtering in Logical Replication