Re: PG 18 beta1 release notes misses mention of pg_noreturn

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Steve Chavez <steve(at)supabase(dot)io>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG 18 beta1 release notes misses mention of pg_noreturn
Date: 2025-07-04 14:23:25
Message-ID: CAExHW5s+GHMnZ+prhJ-yN4U4+zYuLk2gb-cOBX3yp5JLagimYw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 3, 2025 at 8:08 PM Steve Chavez <steve(at)supabase(dot)io> wrote:
>
> Yes, otherwise I had to grep the commits in `git log` and find what's the correct way to use `pg_noreturn`.
> It's not a simple keyword replacement since the order has to change now:
>
> Old: void my_worker(Datum main_arg) pg_attribute_noreturn();
>
> New: pg_noreturn void my_worker(Datum main_arg);
>
> I've added the link to the commit in the patch, which should be enough to infer the above.
>
> How can I get this committed? Is the hacker mailing list the right place for release notes correction?
>

This is the right place to discuss this. Please add your patch to the
commitfest App. https://commitfest.postgresql.org/. The landing page
has a useful link for first timers.

> Best regards,
> Steve Chavez
>

Please do not top-post, reply inline as I have done.

--
Best Wishes,
Ashutosh Bapat

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-07-04 14:29:35 Re: amcheck: Remove unused IndexCheckableCallback typedef
Previous Message Matheus Alcantara 2025-07-04 14:21:52 Re: POC: Parallel processing of indexes in autovacuum