| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: amcheck: Remove unused IndexCheckableCallback typedef |
| Date: | 2025-07-04 14:29:35 |
| Message-ID: | 5c3ebd10-9773-440d-93ae-d5f737827ca1@oss.nttdata.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025/07/04 17:25, Andrey Borodin wrote:
>
>
>> On 4 Jul 2025, at 10:50, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>
>> From the discussion in [1], it seems this typedef was originally used as
>> a function argument in early versions of the patch. However,
>> the argument was removed in v23, and the typedef was accidentally left behind.
>
> Yes, your analysis is correct. We could make common checking function and argument was not needed.
>
>>
>> The attached patch removes this unused typedef to clean up the dead code.
>> Thoughts?
>
> Looks good to me. Thanks for fixing this!
Thanks for the review! I've pushed the patch.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2025-07-04 14:41:51 | Re: Changing shared_buffers without restart |
| Previous Message | Ashutosh Bapat | 2025-07-04 14:23:25 | Re: PG 18 beta1 release notes misses mention of pg_noreturn |