Re: PG 18 beta1 release notes misses mention of pg_noreturn

From: Steve Chavez <steve(at)supabase(dot)io>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG 18 beta1 release notes misses mention of pg_noreturn
Date: 2025-07-03 14:38:26
Message-ID: CAGRrpzbk-FgW=Pr7ufRwS-wuG_8rgWgF5WLjTt4m3j3Y2Yi59g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Yes, otherwise I had to grep the commits in `git log` and find what's the
correct way to use `pg_noreturn`.
It's not a simple keyword replacement since the order has to change now:

Old: void my_worker(Datum main_arg) pg_attribute_noreturn();

New: pg_noreturn void my_worker(Datum main_arg);

I've added the link to the commit in the patch, which should be enough to
infer the above.

How can I get this committed? Is the hacker mailing list the right place
for release notes correction?

Best regards,
Steve Chavez

On Wed, 2 Jul 2025 at 11:24, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

> > On 2 Jul 2025, at 04:51, Steve Chavez <steve(at)supabase(dot)io> wrote:
>
> > While updating an extension to support 18beta1, I stumbled on the
> removal of `pg_attribute_noreturn()` in favor of `pg_noreturn`, which
> wasn't mentioned in the release notes.
>
> That admittedly seems like something worth including since it's otherwise
> not
> documented anywhere.
>
> --
> Daniel Gustafsson
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2025-07-03 14:49:34 Re: Adding basic NUMA awareness
Previous Message jian he 2025-07-03 14:31:13 Re: pg_restore --no-policies should not restore policies' comment