| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Flushing large data immediately in pqcomm |
| Date: | 2024-04-08 12:05:56 |
| Message-ID: | CAEudQAr05GsD-Lt8oZddf1L+KZp81oSaaaw_tw7X7sHwDOQNtA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em seg., 8 de abr. de 2024 às 07:42, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
escreveu:
> On Sun, 7 Apr 2024 at 14:41, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > Looking at the code in socket_putmessage_noblock(), I don't understand
> > why it's ok for PqSendBufferSize to be int but "required" must be
> > size_t. There's a line that does "PqSendBufferSize = required;". It
> > kinda looks like they both should be size_t. Am I missing something
> > that you've thought about?
>
>
> You and Ranier are totally right (I missed this assignment). Attached is
> v8.
>
+1
LGTM.
best regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2024-04-08 12:21:30 | Re: Add last_commit_lsn to pg_stat_database |
| Previous Message | Alexander Lakhin | 2024-04-08 12:00:00 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |