| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Subject: | Re: Flushing large data immediately in pqcomm |
| Date: | 2024-04-08 10:42:23 |
| Message-ID: | CAGECzQRy1DBTkhKgnoFcep5JNk-eGt71Dtf_axc1ihGzXnakFQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 7 Apr 2024 at 14:41, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> Looking at the code in socket_putmessage_noblock(), I don't understand
> why it's ok for PqSendBufferSize to be int but "required" must be
> size_t. There's a line that does "PqSendBufferSize = required;". It
> kinda looks like they both should be size_t. Am I missing something
> that you've thought about?
You and Ranier are totally right (I missed this assignment). Attached is v8.
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Make-a-few-variables-size_t-in-pqcomm.c.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2024-04-08 10:43:51 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Previous Message | Amit Kapila | 2024-04-08 10:31:41 | Re: Synchronizing slots from primary to standby |