| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Mark G <markg735(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing const in DSA. |
| Date: | 2018-09-25 03:01:17 |
| Message-ID: | CAEepm=3aCRzh35kYJf_2Eq39ALKhUXLzqHcrKFE=DwDQ3Y7FcA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 25, 2018 at 7:46 AM Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Tue, Sep 25, 2018 at 4:17 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> > > On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >> Mark G <markg735(at)gmail(dot)com> writes:
> > >>> While looking at some of the recent churn in DSA I noticed that
> > >>> dsa_size_class_map should probably be declared const.
> >
> > >> +1 ... also, given the contents of the array, "char" seems like
> > >> rather a misnomer. I'd be happier if it were declared as uint8, say.
Pushed. Thanks both for the code review!
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2018-09-25 03:46:14 | Re: Revoke execution permission of pg_stat_statements_reset() from pg_read_all_stats role |
| Previous Message | Michael Paquier | 2018-09-25 02:50:47 | Re: Proposal for Signal Detection Refactoring |