| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Mark G <markg735(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing const in DSA. |
| Date: | 2018-09-24 19:46:45 |
| Message-ID: | CAEepm=25Rq4ev3b4xEbAzo1E6DFQQNa1yVTs3t-Dv5spwm2FNQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 25, 2018 at 4:17 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> > On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Mark G <markg735(at)gmail(dot)com> writes:
> >>> While looking at some of the recent churn in DSA I noticed that
> >>> dsa_size_class_map should probably be declared const.
>
> >> +1 ... also, given the contents of the array, "char" seems like
> >> rather a misnomer. I'd be happier if it were declared as uint8, say.
>
> > +1
>
> Are you planning to take care of this?
Will do.
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-09-24 19:50:48 | Re: Explain is slow with tables having many columns |
| Previous Message | legrand legrand | 2018-09-24 19:43:44 | Re: Explain is slow with tables having many columns |