Re: Missing const in DSA.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: markg735(at)gmail(dot)com, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing const in DSA.
Date: 2018-09-24 16:17:40
Message-ID: 10165.1537805860@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Mark G <markg735(at)gmail(dot)com> writes:
>>> While looking at some of the recent churn in DSA I noticed that
>>> dsa_size_class_map should probably be declared const.

>> +1 ... also, given the contents of the array, "char" seems like
>> rather a misnomer. I'd be happier if it were declared as uint8, say.

> +1

Are you planning to take care of this?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Douglas Doole 2018-09-24 16:26:10 Re: Collation versioning
Previous Message Tom Lane 2018-09-24 16:02:35 Re: Revoke execution permission of pg_stat_statements_reset() from pg_read_all_stats role