Re: Size and size_t in dsa API

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Size and size_t in dsa API
Date: 2018-09-20 09:47:07
Message-ID: CAEepm=0k_3EeeJozFFdkd72jXX75=YnFPSxpawwSosjLhPKxJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 20, 2018 at 6:28 PM Ideriha, Takeshi
<ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com> wrote:
> As a non-expert developer's opinion, I think mixing of Size and size_t makes difficult to understand source code.

Agreed. Let's change them all to size_t and back-patch that to keep
future back-patching easy. Patch attached.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
0001-Use-size_t-consistently-in-dsa.-ch.patch application/octet-stream 13.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marco Slot 2018-09-20 10:00:18 Segfault when creating partition with a primary key and sql_drop trigger exists
Previous Message Etsuro Fujita 2018-09-20 09:16:30 Re: Is it possible for postgres_fdw to push down queries on co-located tables?