| From: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Incorrect comment in heapam.c |
| Date: | 2011-12-21 11:21:44 |
| Message-ID: | CAEYLb_Vj0hPM5-0Uto_L14OFVf2KbpTvEpDn4qxTEqoz+5kHSw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 20 December 2011 18:11, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
>>> In fact, that macro is defined in access/htup.h...should it be?
>
>> IMHO comment is wrong, code is in the right place.
>
> It used to be in heapam.h ... evidently, whoever moved it missed this
> comment.
I imagined that that was the case.
It's a fairly inconsequential bug, but it is worth fixing...
--
Peter Geoghegan http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrea Grassi | 2011-12-21 11:46:01 | R: R: R: R: R: BUG #6342: libpq blocks forever in "poll" function |
| Previous Message | Martin Pitt | 2011-12-21 08:09:41 | Re: [PATCH v2] Use CC atomic builtins as a fallback |