| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Incorrect comment in heapam.c |
| Date: | 2012-01-17 01:37:52 |
| Message-ID: | CA+TgmoY0uA3PtUeF85GsU=OAZQniL76+un58fO0rQsGk0bYkCQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Dec 21, 2011 at 6:21 AM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> On 20 December 2011 18:11, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>>> On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
>>>> In fact, that macro is defined in access/htup.h...should it be?
>>
>>> IMHO comment is wrong, code is in the right place.
>>
>> It used to be in heapam.h ... evidently, whoever moved it missed this
>> comment.
>
> I imagined that that was the case.
>
> It's a fairly inconsequential bug, but it is worth fixing...
Fixed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-01-17 01:54:53 | Re: fatal flex error in guc-file.l kills the postmaster |
| Previous Message | yamt | 2012-01-16 09:32:24 | BUG #6399: knngist sometimes returns tuples in incorrect order |