| From: | Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove custom redundant full page write description from GIN |
| Date: | 2025-10-13 20:24:44 |
| Message-ID: | CAE7r3MK_qKkzb0FZ5DMukiVs8PAeFkUacWLRTXqSMhUBsDD2Fg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, Oct 10, 2025 at 10:00 PM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
>
>
> > On 9 Oct 2025, at 17:33, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> >
> > Should we remove them, reducing overall cognitive complexity of GIN
> > internals and reducing WAL footprint?
>
> The patch does not add a single line... that's impressive :)
>
> Why not wipe ginxlogSplit entirely? Will the code be clearer with XLogRegisterData(&flags, sizeof(uint16))?
>
>
Looks like we will not be able to process old split records after
this, as 'flags' field offset was changed. So probably these fields
are for backward compatibility. Does it make sense?
Best regards,
Arseniy Mukhin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-10-13 20:29:40 | Re: Improve docs for n_distinct_inherited |
| Previous Message | Robert Haas | 2025-10-13 20:24:07 | Re: Thoughts on a "global" client configuration? |