Re: Remove custom redundant full page write description from GIN

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove custom redundant full page write description from GIN
Date: 2025-10-10 18:59:52
Message-ID: 81BFE0A1-3298-47FB-BA16-DB55ED1A0660@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 9 Oct 2025, at 17:33, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> Should we remove them, reducing overall cognitive complexity of GIN
> internals and reducing WAL footprint?

The patch does not add a single line... that's impressive :)

Why not wipe ginxlogSplit entirely? Will the code be clearer with XLogRegisterData(&flags, sizeof(uint16))?

Best regards, Andrey Borodin.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2025-10-10 19:35:16 Re: Bypassing cursors in postgres_fdw to enable parallel plans
Previous Message Joel Jacobson 2025-10-10 18:46:04 Re: Optimize LISTEN/NOTIFY