| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Ning Yu <nyu(at)pivotal(dot)io>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: New Defects reported by Coverity Scan for PostgreSQL |
| Date: | 2018-11-06 17:40:21 |
| Message-ID: | CAE2gYzyYimNSXA67Uqm6pLpqYTVGAMRmLZwrxYrk8=CFsVW5QQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> Surely the comment in line 3839 deserves an update :-)
Done.
> This seems good material. I would put the detailed conventions comment
> separately from the head of the file, like this (where I also changed
> "Type1 *type1" into "Type1 *obj1", and a few "has" to "have")
Looks better to me. I found one more "has" and changed it.
| Attachment | Content-Type | Size |
|---|---|---|
| geo-ops-comments-v02.patch | application/octet-stream | 14.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-06 18:25:38 | pgsql: Rename rbtree.c functions to use "rbt" prefix not "rb" prefix. |
| Previous Message | Alvaro Herrera | 2018-11-06 17:32:10 | Re: New Defects reported by Coverity Scan for PostgreSQL |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-11-06 17:45:01 | Re: Issue with v11.0 within jsonb_plperl tests in 32bit on AIX |
| Previous Message | Alvaro Herrera | 2018-11-06 17:35:27 | Re: valgrind issues on Fedora 28 |