| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, tomas(dot)vondra(at)2ndquadrant(dot)com, nyu(at)pivotal(dot)io, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: New Defects reported by Coverity Scan for PostgreSQL |
| Date: | 2018-11-06 17:32:10 |
| Message-ID: | 20181106173210.46xq6mcsp3b6a2h7@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2018-Nov-06, Emre Hasegeli wrote:
> The patch is attached to improve the comments and variable names. I
> explained the functions with the same signature on the file header. I
> can duplicate those on the function headers if you find that better.
Surely the comment in line 3839 deserves an update :-)
This seems good material. I would put the detailed conventions comment
separately from the head of the file, like this (where I also changed
"Type1 *type1" into "Type1 *obj1", and a few "has" to "have")
Thanks
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| geo-ops-comments-v01.patch | text/x-diff | 9.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Emre Hasegeli | 2018-11-06 17:40:21 | Re: New Defects reported by Coverity Scan for PostgreSQL |
| Previous Message | Emre Hasegeli | 2018-11-06 17:19:28 | Re: New Defects reported by Coverity Scan for PostgreSQL |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-11-06 17:35:00 | Re: valgrind issues on Fedora 28 |
| Previous Message | REIX, Tony | 2018-11-06 17:32:03 | RE: Issue with v11.0 within jsonb_plperl tests in 32bit on AIX |