| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Ning Yu <nyu(at)pivotal(dot)io>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: New Defects reported by Coverity Scan for PostgreSQL |
| Date: | 2018-11-15 15:20:33 |
| Message-ID: | 20181115152033.4m3j2fsxohvahzak@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2018-Nov-06, Emre Hasegeli wrote:
> > Surely the comment in line 3839 deserves an update :-)
>
> Done.
>
> > This seems good material. I would put the detailed conventions comment
> > separately from the head of the file, like this (where I also changed
> > "Type1 *type1" into "Type1 *obj1", and a few "has" to "have")
>
> Looks better to me. I found one more "has" and changed it.
Pushed, with some further minor changes. I decided not to remove the
redundant comments that your patch was removing, as I felt that it's
better to keep the API contract together with the function definition.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-11-15 15:33:35 | Re: pgsql: Add flag values in WAL description to all heap records |
| Previous Message | Alvaro Herrera | 2018-11-15 15:18:55 | pgsql: geo_ops.c: Clarify comments and function arguments |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2018-11-15 15:26:43 | Re: [PATCH] Opclass parameters |
| Previous Message | James Coleman | 2018-11-15 14:28:03 | Re: Index Skip Scan |