| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Cc: | tomas(dot)vondra(at)2ndquadrant(dot)com, nyu(at)pivotal(dot)io, alvherre(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: New Defects reported by Coverity Scan for PostgreSQL |
| Date: | 2018-11-06 17:19:28 |
| Message-ID: | CAE2gYzx2BgYm=M9Cx0e1cCPPyA7ecWry_0=8oGfCcFEU=KTJUA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> Good idea. I haven't though about that, but now such names makes more
> sense to me. I will prepare another patch to improve the naming and
> comments to be applied on top of my current patches.
The patch is attached to improve the comments and variable names. I
explained the functions with the same signature on the file header. I
can duplicate those on the function headers if you find that better.
| Attachment | Content-Type | Size |
|---|---|---|
| geo-ops-comments-v00.patch | application/octet-stream | 14.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-11-06 17:32:10 | Re: New Defects reported by Coverity Scan for PostgreSQL |
| Previous Message | Tom Lane | 2018-11-06 15:58:11 | pgsql: Remove useless symbol from Makefile.global. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-11-06 17:24:55 | valgrind issues on Fedora 28 |
| Previous Message | Alvaro Herrera | 2018-11-06 17:18:38 | Re: pg_dump multi VALUES INSERT |