Re: pgsql: Fix compiler warning for ppoll() on Cygwin

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix compiler warning for ppoll() on Cygwin
Date: 2019-12-26 21:30:04
Message-ID: CAD5tBcLJeyuX5b6jBJZ-4kc=jjZ22Zji_CnuPfxrBUcN3JtxxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Dec 26, 2019 at 4:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> > I think the config.cache of lorikeet needs to be cleaned, because the
> > return type of strerror_r() has changed as a result of this commit, but
> > the build farm logs still show the old test result being used from the
> > cache.
>
> lorikeet's latest build run appears to have been done without config
> cache, and it succeeded, so your guess was correct.
>
> Next question is why the buildfarm client got that wrong. Seems like
> its accache logic needs to notice changes in src/template/* as well as
> the configure script proper.
>
>
>

The problem with that is that a change in one template will cause the cache
to be invalidated for every buildfarm member. Maybe that doesn't matter too
much - after all we used not to keep the cache at all.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2019-12-26 22:51:29 Re: pgsql: Superuser can permit passwordless connections on postgres_fdw
Previous Message Tom Lane 2019-12-26 20:19:53 pgsql: Fix possible loss of sync between rectypeid and underlying PLpgS