Re: pgsql: Fix compiler warning for ppoll() on Cygwin

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix compiler warning for ppoll() on Cygwin
Date: 2019-12-26 23:54:38
Message-ID: 9697.1577404478@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On Thu, Dec 26, 2019 at 4:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Next question is why the buildfarm client got that wrong. Seems like
>> its accache logic needs to notice changes in src/template/* as well as
>> the configure script proper.

> The problem with that is that a change in one template will cause the cache
> to be invalidated for every buildfarm member. Maybe that doesn't matter too
> much - after all we used not to keep the cache at all.

I don't think we change those templates often enough for that to be
much of a concern. Trying to make the buildfarm script smart enough
to check only the relevant template seems like more trouble than it'd
be worth.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-12-27 00:07:17 Re: pgsql: Superuser can permit passwordless connections on postgres_fdw
Previous Message Michael Paquier 2019-12-26 23:20:17 Re: pgsql: Rename files and headers related to index AM