Re: pgsql: Superuser can permit passwordless connections on postgres_fdw

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Superuser can permit passwordless connections on postgres_fdw
Date: 2019-12-26 22:51:29
Message-ID: CAA8=A7-BHHo-3Jd9bfa1M8ARZZkwv4ZafwXeS6ZVGoKx8MV62w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Dec 25, 2019 at 12:56 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Dec 20, 2019 at 10:17:20PM -0500, Tom Lane wrote:
> > Yeah, it's sort of annoying that the buildfarm didn't notice this
> > aspect of things. I'm not sure I want to spend cycles on checking
> > it in every test run, though.
> >
> > Maybe we could have -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS
> > enable a check for that aspect along with what it does now?
>
> Makes sense to restrict that under the flag. Perhaps a catalog scan
> of pg_authid at the end of pg_regress and isolationtester then?

What's the preferred way to set that?

"configure CPPFLAGS=-DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS"?

Maybe I should add that to the sample buildfarm config ...

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-12-26 23:15:36 pgsql: Revert "Rename files and headers related to index AM"
Previous Message Andrew Dunstan 2019-12-26 21:30:04 Re: pgsql: Fix compiler warning for ppoll() on Cygwin

Browse pgsql-hackers by date

  From Date Subject
Next Message Maciek Sakrejda 2019-12-26 23:31:16 Re: Duplicate Workers entries in some EXPLAIN plans
Previous Message Alvaro Herrera 2019-12-26 21:58:37 Re: Libpq support to connect to standby server as priority