| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Missing import in 035_standby_logical_decoding.pl |
| Date: | 2025-08-01 22:22:06 |
| Message-ID: | CAD21AoDtjLGdqHi=PZECmHSS66ZbksSCTncbYjQe+DcSTErxQQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 1, 2025 at 1:58 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Fri, Aug 1, 2025 at 3:04 PM Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
> >
> > 035_standby_logical_decoding.pl has this code
>
> Another issue I see is that there are two incorrect tests for a log message
>
> # message should not be issued
> ok( !$node_standby->log_contains(
> "invalidating obsolete slot \"no_conflict_inactiveslot\"", $logstart),
> 'inactiveslot slot invalidation is not logged with vacuum on conflict_test'
> );
>
> ok( !$node_standby->log_contains(
> "invalidating obsolete slot \"no_conflict_activeslot\"", $logstart),
> 'activeslot slot invalidation is not logged with vacuum on conflict_test'
> );
>
> This will never fail because the message string is actually
> "invalidating obsolete replication slot"
>
> It is correctly specified elsewhere in the same test.
> so, that should be fixed too.
+1
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-08-01 22:46:39 | Re: pg_dump --with-* options |
| Previous Message | Masahiko Sawada | 2025-08-01 22:19:47 | Re: Missing import in 035_standby_logical_decoding.pl |