| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Missing import in 035_standby_logical_decoding.pl |
| Date: | 2025-08-01 20:57:50 |
| Message-ID: | CAAKRu_a7gYu1M0LA0T6C0y54XOJRiYqkTZmrmewOfrik+uJ_uw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 1, 2025 at 3:04 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> 035_standby_logical_decoding.pl has this code
Another issue I see is that there are two incorrect tests for a log message
# message should not be issued
ok( !$node_standby->log_contains(
"invalidating obsolete slot \"no_conflict_inactiveslot\"", $logstart),
'inactiveslot slot invalidation is not logged with vacuum on conflict_test'
);
ok( !$node_standby->log_contains(
"invalidating obsolete slot \"no_conflict_activeslot\"", $logstart),
'activeslot slot invalidation is not logged with vacuum on conflict_test'
);
This will never fail because the message string is actually
"invalidating obsolete replication slot"
It is correctly specified elsewhere in the same test.
so, that should be fixed too.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-08-01 21:36:19 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |
| Previous Message | Alexander Borisov | 2025-08-01 20:51:04 | Re: Improve the performance of Unicode Normalization Forms. |