Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
Date: 2021-06-30 11:48:14
Message-ID: CAD21AoCzLHfU0kGxBkAOyn-2qrCfMHXk0H+0MpLs6inx3x=gqw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 30, 2021 at 5:12 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jun 29, 2021 at 6:07 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Tue, Jun 29, 2021 at 5:12 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > > Hi all,
> > >
> > > I realized that we use the magic number 10 instead of
> > > PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
> > > function. It seems an oversight of the original commit. Attached patch
> > > fixes it.
> > >
> >
> > LGTM. I'll take care of it tomorrow.
> >
>
> Pushed.

Thanks!

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-06-30 12:07:55 Re: Allow streaming the changes after speculative aborts.
Previous Message vignesh C 2021-06-30 11:43:21 Re: Added schema level support for publication.