Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
Date: 2021-06-30 08:12:37
Message-ID: CAA4eK1LqLQ1B_4Q1KG1PGOGRowqRRHWcKdLMhGecrt2R85_dUw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 29, 2021 at 6:07 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jun 29, 2021 at 5:12 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > Hi all,
> >
> > I realized that we use the magic number 10 instead of
> > PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
> > function. It seems an oversight of the original commit. Attached patch
> > fixes it.
> >
>
> LGTM. I'll take care of it tomorrow.
>

Pushed.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-06-30 08:14:23 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Michael Paquier 2021-06-30 08:05:15 Re: pgbench logging broken by time logic changes