| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Date: | 2025-12-24 18:52:05 |
| Message-ID: | CAD21AoCanNCGuLLwz7fcY4uMO3Kwhw2UrvAibn_UzB1U=hiS+Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 24, 2025 at 12:42 AM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Hi,
>
> I noticed a BF failure [1] related to this commit.
>
> Commit 67c209 removes the WARNING for insufficient wal_level from the output,
> but the WARNING may still appear on BF animals that default to
> wal_level=minimal.
>
> To avoid tests that produce varying messages based on wal_level, we could modify
> the test to use ALTER PUBLICATION for verifying the same NOTICE. Attached is a
> small patch addressing this issue.
>
> We could also simply remove these tests but that seems to reduce the test
> coverage a bit.
Thank you for reporting this issue and creating the patch!
The change looks good to me, and I've confirmed that regression tests
with the same configuration as thorntail pass with the proposed patch.
So I've pushed the patch.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2025-12-24 19:58:20 | Re: DOCS - Clarify the publication 'publish_via_partition_root' default value. |
| Previous Message | Tom Lane | 2025-12-24 18:16:41 | Re: should we have a fast-path planning for OLTP starjoins? |